Re: [PATCH 0/4] Add Support for GET LBA STATUS 16 command in scsi emulation

[no-reply]

Patchew URL: 20200602074201.10879-1-lma@suse.com/">https://patchew.org/QEMU/20200602074201.10879-1-lma@suse.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200602074201.10879-1-lma@suse.com
Subject: [PATCH 0/4] Add Support for GET LBA STATUS 16 command in scsi emulation
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
f21fd54 scsi-disk: Add support for the GET LBA STATUS 16 command
1cf515c block: Add block accounting code for GET LBA STATUS
fb4af56 block: Add GET LBA STATUS support
3e12b00 block: Add bdrv_co_get_lba_status

=== OUTPUT BEGIN ===
1/4 Checking commit 3e12b00c0380 (block: Add bdrv_co_get_lba_status)
ERROR: superfluous trailing semicolon
#47: FILE: block/io.c:2215:
+                wanted_bit1 = BDRV_BLOCK_ZERO >> 1;;

total: 1 errors, 0 warnings, 49 lines checked

Patch 1/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/4 Checking commit fb4af5679e29 (block: Add GET LBA STATUS support)
3/4 Checking commit 1cf515c04a31 (block: Add block accounting code for GET LBA 
STATUS)
4/4 Checking commit f21fd540cc03 (scsi-disk: Add support for the GET LBA STATUS 
16 command)
WARNING: Block comments use a leading /* on a separate line
#81: FILE: hw/scsi/scsi-disk.c:1932:
+    /* 8 + 16 is the length in bytes of response header and

total: 0 errors, 1 warnings, 111 lines checked

Patch 4/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200602074201.10879-1-lma@suse.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200602074201.10879-1-lma@suse.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com