[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] block/quorum.c: Decrease child index when del_child
|
From: |
Zhang, Chen |
|
Subject: |
RE: [PATCH] block/quorum.c: Decrease child index when del_child |
|
Date: |
Tue, 2 Jun 2020 00:59:35 +0000 |
Oh, I missed the patch detail. I just reviewed overall view on your series.
Looks your patch is good for me.
Thanks
Zhang Chen
> -----Original Message-----
> From: Lukas Straub <lukasstraub2@web.de>
> Sent: Tuesday, June 2, 2020 2:12 AM
> To: Alberto Garcia <berto@igalia.com>
> Cc: Zhang, Chen <chen.zhang@intel.com>; Kevin Wolf <kwolf@redhat.com>;
> Max Reitz <mreitz@redhat.com>; qemu-dev <qemu-devel@nongnu.org>;
> Jason Wang <jasowang@redhat.com>; Zhanghailiang
> <zhang.zhanghailiang@huawei.com>; Dr . David Alan Gilbert
> <dgilbert@redhat.com>; Zhang Chen <zhangckid@gmail.com>
> Subject: Re: [PATCH] block/quorum.c: Decrease child index when del_child
>
> On Mon, 01 Jun 2020 12:38:32 +0200
> Alberto Garcia <berto@igalia.com> wrote:
> > As I explained a few weeks ago this patch is not correct.
> > quorum_del_child() allows you to remove any child from the Quorum
> > device, so nothing guarantees that next_child_index-1 is free.
> >
> > https://lists.gnu.org/archive/html/qemu-block/2020-05/msg00634.html
> >
> > Berto
> >
>
> Hi,
> Did you have a look at my series? There it's fixed properly:
> https://lore.kernel.org/qemu-
> devel/9df6b3723ec30cb749ceaa555d82a29a6d79496d.1589199922.git.lukasstr
> aub2@web.de/
>
> Regards,
> Lukas Straub