[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/5] target/tricore: Raise EXCP_DEBUG in gen_goto_tb() for
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2 3/5] target/tricore: Raise EXCP_DEBUG in gen_goto_tb() for singlestep |
|
Date: |
Mon, 1 Jun 2020 14:04:44 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 5/29/20 12:21 AM, Bastian Koppelmann wrote:
> if (ctx->base.singlestep_enabled) {
> - /* raise exception debug */
> + generate_qemu_excp(ctx, EXCP_DEBUG);
> }
> tcg_gen_exit_tb(NULL, 0);
For preference, put an else here:
if (singlestep) {
generate_qemu_excp();
} else {
tcg_gen_exit_tb();
}
else you emit dead code after the exception.
r~
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 3/5] target/tricore: Raise EXCP_DEBUG in gen_goto_tb() for singlestep,
Richard Henderson <=