[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC 14/32] python//qmp.py: use True/False for non/blocking mo
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH RFC 14/32] python//qmp.py: use True/False for non/blocking modes |
Date: |
Sun, 31 May 2020 12:01:37 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 5/14/20 7:53 AM, John Snow wrote:
> The type system doesn't want integers.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/lib/qmp.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/python/qemu/lib/qmp.py b/python/qemu/lib/qmp.py
> index b91c9d5c1c..a634c4e26c 100644
> --- a/python/qemu/lib/qmp.py
> +++ b/python/qemu/lib/qmp.py
> @@ -120,14 +120,14 @@ def __get_events(self, wait=False):
> """
>
> # Check for new events regardless and pull them into the cache:
> - self.__sock.setblocking(0)
> + self.__sock.setblocking(False)
> try:
> self.__json_read()
> except OSError as err:
> if err.errno == errno.EAGAIN:
> # No data available
> pass
> - self.__sock.setblocking(1)
> + self.__sock.setblocking(True)
>
> # Wait for new events, if needed.
> # if wait is 0.0, this means "no wait" and is also implicitly false.
>
Thanks, applied to my python-next tree:
https://gitlab.com/philmd/qemu/commits/python-next
- [PATCH RFC 07/32] python/qemu: add README.rst, (continued)
- [PATCH RFC 07/32] python/qemu: add README.rst, John Snow, 2020/05/14
- [PATCH RFC 10/32] python/qemu: Add flake8 to Pipfile, John Snow, 2020/05/14
- [PATCH RFC 11/32] python/qemu/lib: remove Python2 style super() calls, John Snow, 2020/05/14
- [PATCH RFC 09/32] python/qemu: add pylint to Pipfile, John Snow, 2020/05/14
- [PATCH RFC 08/32] python/qemu: Add Pipfile, John Snow, 2020/05/14
- [PATCH RFC 15/32] python//qmp.py: Define common types, John Snow, 2020/05/14
- [PATCH RFC 14/32] python//qmp.py: use True/False for non/blocking modes, John Snow, 2020/05/14
- [PATCH RFC 13/32] python/qemu/lib: Adjust traceback typing, John Snow, 2020/05/14
- [PATCH RFC 17/32] python//qmp.py: Do not return None from cmd_obj, John Snow, 2020/05/14
- [PATCH RFC 16/32] python//qmp.py: re-absorb MonitorResponseError, John Snow, 2020/05/14
- [PATCH RFC 18/32] python//qmp.py: add casts to JSON deserialization, John Snow, 2020/05/14
- [PATCH RFC 21/32] python//machine.py: remove logging configuration, John Snow, 2020/05/14