[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] virtio-pci: fix queue_enable write
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH] virtio-pci: fix queue_enable write |
|
Date: |
Fri, 29 May 2020 14:00:06 +0100 |
On Fri, May 29, 2020 at 11:07:28AM +0800, Jason Wang wrote:
> Spec said: The driver uses this to selectively prevent the device from
> executing requests from this virtqueue. 1 - enabled; 0 - disabled.
>
> Though write 0 to queue_enable is forbidden by the sepc, we should not
> assume that the value is 1.
>
> Fix this by ignoring the write value other than 1.
>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
> hw/virtio/virtio-pci.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature