Re: [PATCH v2 00/11] Record/replay acceptance tests

[Philippe Mathieu-Daudé]

On 5/27/20 3:41 PM, address@hidden wrote:
> Patchew URL: 
> https://patchew.org/QEMU/159057543840.16818.14393433996899521784.stgit@pasha-ThinkPad-X280/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
[...]>
> ERROR: line over 90 characters
> #83: FILE: tests/acceptance/replay_linux.py:41:
> +        vm.add_args('-drive', 
> 'driver=blkreplay,id=disk%s-rr,if=none,image=disk%s' % (id, id))
> 
> WARNING: line over 80 characters
> #84: FILE: tests/acceptance/replay_linux.py:42:
> +        vm.add_args('-device', '%s,drive=disk%s-rr%s' % (device, id, 
> bus_string))

Please try to respect the QEMU 80 chars limit (it eases review by blind
developers) and align methods & arguments to QEMU style.

Otherwise I'm glad to see this series.

So far:
Tested-by: Philippe Mathieu-Daude <address@hidden>

I plan to add R-b on v3 once you addressed Alex's comments.

Good job!