[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-ci
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v6 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites |
Date: |
Wed, 27 May 2020 13:29:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
Hi Daniel,
On 5/19/20 8:20 PM, Philippe Mathieu-Daudé wrote:
> Hi,
>
> This series has two parts:
>
> - First we add the ability to QOM objects to produce data
> consumable by the fw_cfg device,
>
> - Then we add the tls-cipher-suites object, and let it
> implement the FW_CFG_DATA_GENERATOR interface.
Can I have a quick feedback that you are not going to NAck this series
later before addressing all comments from Laszlo's reviews?
Thanks!
Phil.
>
> This is required by EDK2 'HTTPS Boot' feature [*] to tell
> the guest which TLS ciphers it can use.
>
> [*]: https://github.com/tianocore/edk2/blob/master/OvmfPkg/README
>
> Since v5:
> - Complete rewrite after chatting with Daniel Berrangé
> Since v4:
> - Addressed Laszlo comments (see patch#1 description)
> Since v3:
> - Addressed Markus' comments (do not care about heap)
> Since v2:
> - Split of
> Since v1:
> - Addressed Michael and Laszlo comments.
>
> Please review,
>
> Phil.
>
> v5: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg04525.html
> v4: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04300.html
> v3: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02965.html
> v2: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02522.html
> v1: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01598.html
> Supersedes: <address@hidden>
>
> Philippe Mathieu-Daudé (5):
> hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interface
> softmmu/vl: Let -fw_cfg option take a 'blob_id' argument
> softmmu/vl: Allow -fw_cfg 'blob_id' option to set any file pathname
> crypto: Add tls-cipher-suites object
> crypto/tls-cipher-suites: Product fw_cfg consumable blob
>
> include/crypto/tls-cipher-suites.h | 39 ++++++++
> include/hw/nvram/fw_cfg.h | 49 ++++++++++
> crypto/tls-cipher-suites.c | 152 +++++++++++++++++++++++++++++
> hw/nvram/fw_cfg.c | 30 ++++++
> softmmu/vl.c | 19 +++-
> crypto/Makefile.objs | 1 +
> 6 files changed, 285 insertions(+), 5 deletions(-)
> create mode 100644 include/crypto/tls-cipher-suites.h
> create mode 100644 crypto/tls-cipher-suites.c
>
- [RFC PATCH v6 3/5] softmmu/vl: Allow -fw_cfg 'blob_id' option to set any file pathname, (continued)