[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] qom: Constify object_get_canonical_path{, _component}()'
From: |
Cédric Le Goater |
Subject: |
Re: [PATCH 1/2] qom: Constify object_get_canonical_path{, _component}()'s parameter |
Date: |
Wed, 27 May 2020 11:02:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 5/27/20 10:47 AM, Markus Armbruster wrote:
> Suggested-by: Eric Blake <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
> ---
> include/qom/object.h | 4 ++--
> qom/object.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/qom/object.h b/include/qom/object.h
> index fd453dc8d6..b3eb05d65d 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -1406,7 +1406,7 @@ Object *object_get_internal_root(void);
> * path is the path within the composition tree starting from the root.
> * %NULL if the object doesn't have a parent (and thus a canonical path).
> */
> -char *object_get_canonical_path_component(Object *obj);
> +char *object_get_canonical_path_component(const Object *obj);
>
> /**
> * object_get_canonical_path:
> @@ -1414,7 +1414,7 @@ char *object_get_canonical_path_component(Object *obj);
> * Returns: The canonical path for a object. This is the path within the
> * composition tree starting from the root.
> */
> -char *object_get_canonical_path(Object *obj);
> +char *object_get_canonical_path(const Object *obj);
>
> /**
> * object_resolve_path:
> diff --git a/qom/object.c b/qom/object.c
> index d0be42c8d6..c02487ec1a 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -1883,7 +1883,7 @@ object_property_add_const_link(Object *obj, const char
> *name,
> NULL, OBJ_PROP_LINK_DIRECT);
> }
>
> -char *object_get_canonical_path_component(Object *obj)
> +char *object_get_canonical_path_component(const Object *obj)
> {
> ObjectProperty *prop = NULL;
> GHashTableIter iter;
> @@ -1908,7 +1908,7 @@ char *object_get_canonical_path_component(Object *obj)
> return NULL;
> }
>
> -char *object_get_canonical_path(Object *obj)
> +char *object_get_canonical_path(const Object *obj)
> {
> Object *root = object_get_root();
> char *newpath, *path = NULL;
>