[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH RFC v3 08/11] KVM: Simplify dirty log sync in kvm_set_phys_mem
From: |
Peter Xu |
Subject: |
[PATCH RFC v3 08/11] KVM: Simplify dirty log sync in kvm_set_phys_mem |
Date: |
Sat, 23 May 2020 19:20:32 -0400 |
kvm_physical_sync_dirty_bitmap() on the whole section is inaccurate, because
the section can be a superset of the memslot that we're working on. The result
is that if the section covers multiple kvm memslots, we could be doing the
synchronization for multiple times for each kvmslot in the section.
With the two helpers that we just introduced, it's very easy to do it right now
by calling the helpers.
Signed-off-by: Peter Xu <address@hidden>
---
accel/kvm/kvm-all.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index 016bad1089..f7c8e6bebe 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -1099,7 +1099,8 @@ static void kvm_set_phys_mem(KVMMemoryListener *kml,
goto out;
}
if (mem->flags & KVM_MEM_LOG_DIRTY_PAGES) {
- kvm_physical_sync_dirty_bitmap(kml, section);
+ kvm_slot_get_dirty_log(kvm_state, mem);
+ kvm_slot_sync_dirty_pages(mem);
}
/* unregister the slot */
--
2.26.2
- Re: [PATCH RFC v3 01/11] linux-headers: Update, (continued)
[PATCH RFC v3 03/11] KVM: Fixup kvm_log_clear_one_slot() ioctl return check, Peter Xu, 2020/05/23
[PATCH RFC v3 02/11] memory: Introduce log_sync_global() to memory listener, Peter Xu, 2020/05/23
[PATCH RFC v3 04/11] KVM: Use a big lock to replace per-kml slots_lock, Peter Xu, 2020/05/23
[PATCH RFC v3 05/11] KVM: Create the KVMSlot dirty bitmap on flag changes, Peter Xu, 2020/05/23
[PATCH RFC v3 06/11] KVM: Provide helper to get kvm dirty log, Peter Xu, 2020/05/23
[PATCH RFC v3 07/11] KVM: Provide helper to sync dirty bitmap from slot to ramblock, Peter Xu, 2020/05/23
[PATCH RFC v3 08/11] KVM: Simplify dirty log sync in kvm_set_phys_mem,
Peter Xu <=
[PATCH RFC v3 09/11] KVM: Cache kvm slot dirty bitmap size, Peter Xu, 2020/05/23
[PATCH RFC v3 10/11] KVM: Add dirty-gfn-count property, Peter Xu, 2020/05/23
[PATCH RFC v3 11/11] KVM: Dirty ring support, Peter Xu, 2020/05/23
Re: [PATCH RFC v3 00/11] KVM: Dirty ring support (QEMU part), Peter Xu, 2020/05/24
Re: [PATCH RFC v3 00/11] KVM: Dirty ring support (QEMU part), Peter Xu, 2020/05/26