[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH V2 4/7] net/colo-compare.c: Only hexdump packets if tracing is en
From: |
Zhang Chen |
Subject: |
[PATCH V2 4/7] net/colo-compare.c: Only hexdump packets if tracing is enabled |
Date: |
Fri, 22 May 2020 15:53:54 +0800 |
From: Lukas Straub <address@hidden>
Else the log will be flooded if there is a lot of network
traffic.
Signed-off-by: Lukas Straub <address@hidden>
Reviewed-by: Zhang Chen <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Zhang Chen <address@hidden>
---
net/colo-compare.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 62ecd38bb7..a609f499b9 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -483,10 +483,12 @@ sec:
g_queue_push_head(&conn->primary_list, ppkt);
g_queue_push_head(&conn->secondary_list, spkt);
- qemu_hexdump((char *)ppkt->data, stderr,
- "colo-compare ppkt", ppkt->size);
- qemu_hexdump((char *)spkt->data, stderr,
- "colo-compare spkt", spkt->size);
+ if (trace_event_get_state_backends(TRACE_COLO_COMPARE_MISCOMPARE)) {
+ qemu_hexdump((char *)ppkt->data, stderr,
+ "colo-compare ppkt", ppkt->size);
+ qemu_hexdump((char *)spkt->data, stderr,
+ "colo-compare spkt", spkt->size);
+ }
colo_compare_inconsistency_notify(s);
}
--
2.17.1
- [PATCH V2 0/7] Latest COLO tree queued patches, Zhang Chen, 2020/05/22
- [PATCH V2 2/7] chardev/char.c: Use qemu_co_sleep_ns if in coroutine, Zhang Chen, 2020/05/22
- [PATCH V2 1/7] net/colo-compare.c: Create event_bh with the right AioContext, Zhang Chen, 2020/05/22
- [PATCH V2 3/7] net/colo-compare.c: Fix deadlock in compare_chr_send, Zhang Chen, 2020/05/22
- [PATCH V2 4/7] net/colo-compare.c: Only hexdump packets if tracing is enabled,
Zhang Chen <=
- [PATCH V2 5/7] net/colo-compare.c: Check that colo-compare is active, Zhang Chen, 2020/05/22
- [PATCH V2 6/7] net/colo-compare.c: Correct ordering in complete and finalize, Zhang Chen, 2020/05/22
- [PATCH V2 7/7] colo-compare: Fix memory leak in packet_enqueue(), Zhang Chen, 2020/05/22
- Re: [PATCH V2 0/7] Latest COLO tree queued patches, Jason Wang, 2020/05/24