[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/24] sd/pxa2xx_mmci: Fix to realize "pxa2xx-mmci" device
From: |
Peter Maydell |
Subject: |
Re: [PATCH 03/24] sd/pxa2xx_mmci: Fix to realize "pxa2xx-mmci" device |
Date: |
Thu, 21 May 2020 17:20:22 +0100 |
On Mon, 18 May 2020 at 06:04, Markus Armbruster <address@hidden> wrote:
>
> pxa2xx_mmci_init() creates a "pxa2xx-mmci" device, but neglects to
> realize it. Affects machines akita, borzoi, connex, mainstone, spitz,
> terrier, tosa, verdex, and z2.
>
> I wonder how this ever worked. If the "device becomes real only on
> realize" thing actually works, then we've always been missing the
> device, yet nobody noticed.
It works by accident: because the device in question happens
to not have a realize method, nothing breaks if we forget
to run the realize method. Undefined behaviour: we happened
to get lucky in this case.
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
[PATCH 14/24] macio: Put "macio-nvram" device on the macio bus, Markus Armbruster, 2020/05/18
[PATCH 04/24] aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" devices, Markus Armbruster, 2020/05/18