qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] qom/container: remove .instance_size initializer from contai


From: Paolo Bonzini
Subject: Re: [PATCH] qom/container: remove .instance_size initializer from container_info
Date: Thu, 21 May 2020 16:46:37 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0

On 13/05/20 05:36, Masahiro Yamada wrote:
> You can omit .instance_size if it is the same as that of the parent.
> 
>     .class_size = sizeof(ObjectClass)
> 
> ... is omitted here, so removing .instance_size is more consistent.
> 
> Signed-off-by: Masahiro Yamada <address@hidden>
> ---
> 
>  qom/container.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/qom/container.c b/qom/container.c
> index f6ccaf7ea7..4c030d6dda 100644
> --- a/qom/container.c
> +++ b/qom/container.c
> @@ -16,7 +16,6 @@
>  
>  static const TypeInfo container_info = {
>      .name          = "container",
> -    .instance_size = sizeof(Object),
>      .parent        = TYPE_OBJECT,
>  };
>  
> 

Queued, thanks.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]