[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/i386: Fix OUTL debug output
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH] target/i386: Fix OUTL debug output |
Date: |
Thu, 21 May 2020 16:06:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 19/05/20 14:23, Philippe Mathieu-Daudé wrote:
> On 5/19/20 5:39 AM, Richard Henderson wrote:
>> On 5/17/20 4:01 AM, Philippe Mathieu-Daudé wrote:
>>> Fix OUTL instructions incorrectly displayed as OUTW.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>>> ---
>>> target/i386/misc_helper.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Reviewed-by: Richard Henderson <address@hidden>
>>
>> as far as it goes. We should of course never be printing to stderr, but
>> logging or tracing.
>
> Yes, this is what the cpu_io() functions do in ioport.c, but they use
> MEMTXATTRS_UNSPECIFIED.
>
> If we could replace one with another, I'm not sure which one is the
> correct one.
>
> Maybe keep cpu_io() from ioport.c but add a MemTxAttrs argument?
>
> Regards,
>
> Phil.
>
Queued, thanks.
Paolo