Re: [PATCH v3 1/9] riscv/boot: Add a missing header include

[Alistair Francis]

On Tue, May 19, 2020 at 11:01 PM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> On 5/19/20 11:31 PM, Alistair Francis wrote:
> > Currently every c file that includes boot.h also includes loader.h
> > before it. Which is why the build works fine. We should be able to
> > include just boot.h though so this is a small fixup to allow that.
>
> What about:
>
> 'As the functions declared in this header use the symbol_fn_t
>   typedef itself declared in "hw/loader.h", we need to include
>   it here to make the header file self-contained.'

Sounds good.

Alistair

>
> >
> > Signed-off-by: Alistair Francis <address@hidden>
> > Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> > Reviewed-by: Bin Meng <address@hidden>
> > ---
> >   include/hw/riscv/boot.h | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/include/hw/riscv/boot.h b/include/hw/riscv/boot.h
> > index 474a940ad5..9daa98da08 100644
> > --- a/include/hw/riscv/boot.h
> > +++ b/include/hw/riscv/boot.h
> > @@ -21,6 +21,7 @@
> >   #define RISCV_BOOT_H
> >
> >   #include "exec/cpu-defs.h"
> > +#include "hw/loader.h"
> >
> >   void riscv_find_and_load_firmware(MachineState *machine,
> >                                     const char *default_machine_firmware,
> >
>