Re: [PATCH 03/55] qdev: New qdev_new(), qdev_realize(), etc.

[Paolo Bonzini]

On 20/05/20 10:11, Markus Armbruster wrote:
>> On 19/05/20 16:54, Markus Armbruster wrote:
>>> +
>>> +    object_ref(OBJECT(dev));
>>> +    object_property_set_bool(OBJECT(dev), true, "realized", &err);
>>> +    if (err) {
>>> +        error_propagate_prepend(errp, err,
>>> +                                "Initialization of device %s failed: ",
>>> +                                object_get_typename(OBJECT(dev)));
>>> +    }
>>> +    object_unref(OBJECT(dev));
>> Why is the ref/unref pair needed?  Should it be done in the realized
>> setter instead?
> Copied from qdev_init_nofail(), where it is necessary (I figured out why
> the hard way).  It doesn't seem to be necessary here, though.  Thanks!

Why is it necessary there?  It seems a bit iffy.

Paolo