qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 8/8] target/arm: Use a non-overlapping group for misc control


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 8/8] target/arm: Use a non-overlapping group for misc control
Date: Mon, 18 May 2020 18:56:04 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 5/18/20 6:40 PM, Richard Henderson wrote:
This sub-group in the t32 deocode are mutually exclusive.

"The miscellaneous control instructions are mutually exclusive within the t32 decode sub-group."?

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


Signed-off-by: Richard Henderson <address@hidden>
---
  target/arm/t32.decode | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/arm/t32.decode b/target/arm/t32.decode
index c63082fc9c..c21a988f97 100644
--- a/target/arm/t32.decode
+++ b/target/arm/t32.decode
@@ -312,13 +312,13 @@ CLZ              1111 1010 1011 ---- 1111 .... 1000 ....  
    @rdm
                   &cps
# Miscellaneous control
-    {
+    [
        CLREX      1111 0011 1011 1111 1000 1111 0010 1111
        DSB        1111 0011 1011 1111 1000 1111 0100 ----
        DMB        1111 0011 1011 1111 1000 1111 0101 ----
        ISB        1111 0011 1011 1111 1000 1111 0110 ----
        SB         1111 0011 1011 1111 1000 1111 0111 0000
-    }
+    ]
# Note that the v7m insn overlaps both the normal and banked insn.
      {




reply via email to

[Prev in Thread] Current Thread [Next in Thread]