[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/24] ppc4xx: Drop redundant device realization
From: |
Thomas Huth |
Subject: |
Re: [PATCH 13/24] ppc4xx: Drop redundant device realization |
Date: |
Mon, 18 May 2020 18:41:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 18/05/2020 07.03, Markus Armbruster wrote:
> object_property_set_bool(OBJECT(dev), true, "realized", ...) right
> after qdev_init_nofail(dev) does nothing, because qdev_init_nofail()
> already realizes. Drop.
>
> Cc: BALATON Zoltan <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> hw/ppc/ppc440_uc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c
> index b30e093cbb..dc318c7aa7 100644
> --- a/hw/ppc/ppc440_uc.c
> +++ b/hw/ppc/ppc440_uc.c
> @@ -1370,12 +1370,10 @@ void ppc460ex_pcie_init(CPUPPCState *env)
> dev = qdev_create(NULL, TYPE_PPC460EX_PCIE_HOST);
> qdev_prop_set_int32(dev, "dcrn-base", DCRN_PCIE0_BASE);
> qdev_init_nofail(dev);
> - object_property_set_bool(OBJECT(dev), true, "realized", NULL);
> ppc460ex_pcie_register_dcrs(PPC460EX_PCIE_HOST(dev), env);
>
> dev = qdev_create(NULL, TYPE_PPC460EX_PCIE_HOST);
> qdev_prop_set_int32(dev, "dcrn-base", DCRN_PCIE1_BASE);
> qdev_init_nofail(dev);
> - object_property_set_bool(OBJECT(dev), true, "realized", NULL);
> ppc460ex_pcie_register_dcrs(PPC460EX_PCIE_HOST(dev), env);
> }
>
Reviewed-by: Thomas Huth <address@hidden>
- [PATCH 15/24] macio: Fix macio-bus to be a subtype of System bus, (continued)
- [PATCH 15/24] macio: Fix macio-bus to be a subtype of System bus, Markus Armbruster, 2020/05/18
- [PATCH 19/24] riscv: Fix to put "riscv.hart_array" devices on sysbus, Markus Armbruster, 2020/05/18
- [PATCH 13/24] ppc4xx: Drop redundant device realization, Markus Armbruster, 2020/05/18
- [PATCH 11/24] pnv/phb4: Bury unwanted "pnv-phb4-pec-stack" devices, Markus Armbruster, 2020/05/18
- [PATCH 17/24] pnv/psi: Correct the pnv-psi* devices not to be sysbus devices, Markus Armbruster, 2020/05/18
- [PATCH 23/24] sd: Hide the qdev-but-not-quite thing created by sd_init(), Markus Armbruster, 2020/05/18