Re: [PATCH not-for-merge 0/5] Instrumentation for "Fixes around device realization"

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [PATCH not-for-merge 0/5] Instrumentation for "Fixes around device 
realization"
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
433c653 qdev: Instrument to detect bus mismatch
45b1ab7 qdev: Instrument to detect missed QOM parenting
90adce3 qdev: Make "info qtree" show child devices sorted by QOM path
f817193 qom: Make "info qom-tree" show children sorted
4f1a7d1 qom: Instrument to detect missed realize

=== OUTPUT BEGIN ===
1/5 Checking commit 4f1a7d11f0d3 (qom: Instrument to detect missed realize)
WARNING: line over 80 characters
#20: FILE: qom/qom-hmp-cmds.c:96:
+    DeviceClass *dc = (DeviceClass *)object_class_dynamic_cast(obj->class, 
TYPE_DEVICE);

total: 0 errors, 1 warnings, 17 lines checked

Patch 1/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/5 Checking commit f817193d8f6b (qom: Make "info qom-tree" show children 
sorted)
3/5 Checking commit 90adce33a3ce (qdev: Make "info qtree" show child devices 
sorted by QOM path)
4/5 Checking commit 45b1ab79bf00 (qdev: Instrument to detect missed QOM 
parenting)
5/5 Checking commit 433c65363b48 (qdev: Instrument to detect bus mismatch)
ERROR: line over 90 characters
#23: FILE: hw/core/qdev.c:106:
+             bc = (BusClass 
*)object_class_dynamic_cast(object_class_get_parent(OBJECT_CLASS(bc)), 
TYPE_BUS)) {

WARNING: line over 80 characters
#24: FILE: hw/core/qdev.c:107:
+            if (!g_strcmp0(dc->bus_type, 
object_class_get_name(OBJECT_CLASS(bc)))) {

total: 1 errors, 1 warnings, 23 lines checked

Patch 5/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden