Re: [PATCH v6 00/16] acpi: i386 tweaks

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [PATCH v6 00/16] acpi: i386 tweaks
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
9adb28d acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.
646a108 acpi: drop build_piix4_pm()
6324bba acpi: drop serial/parallel enable bits from dsdt
4a8ceb8 acpi: simplify build_isa_devices_aml()
d8ccc6f acpi: factor out fw_cfg_add_acpi_dsdt()
e0c5fc4 acpi: move aml builder code for i8042 (kbd+mouse) device
4eb0cc0 floppy: move cmos_get_fd_drive_type() from pc
71d56fa floppy: make isa_fdc_get_drive_max_chs static
c895a16 acpi: move aml builder code for floppy device
41e32d4 acpi: move aml builder code for parallel device
fe41881 acpi: parallel: don't use _STA method
bcb5ae4 acpi: move aml builder code for serial device
49e11f9 acpi: serial: don't use _STA method
6e7ae5d acpi: rtc: use a single crs range
e1b1294 acpi: move aml builder code for rtc device
10fc2d4 qtest: allow DSDT acpi table changes

=== OUTPUT BEGIN ===
1/16 Checking commit 10fc2d45a6fa (qtest: allow DSDT acpi table changes)
2/16 Checking commit e1b1294da937 (acpi: move aml builder code for rtc device)
3/16 Checking commit 6e7ae5d0138b (acpi: rtc: use a single crs range)
4/16 Checking commit 49e11f9e91f4 (acpi: serial: don't use _STA method)
5/16 Checking commit bcb5ae4dd8b1 (acpi: move aml builder code for serial 
device)
6/16 Checking commit fe4188155acf (acpi: parallel: don't use _STA method)
7/16 Checking commit 41e32d4b35c3 (acpi: move aml builder code for parallel 
device)
8/16 Checking commit c895a1614849 (acpi: move aml builder code for floppy 
device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#245: 
new file mode 100644

total: 0 errors, 1 warnings, 221 lines checked

Patch 8/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/16 Checking commit 71d56fa8b146 (floppy: make isa_fdc_get_drive_max_chs 
static)
10/16 Checking commit 4eb0cc051852 (floppy: move cmos_get_fd_drive_type() from 
pc)
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 82 lines checked

Patch 10/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/16 Checking commit e0c5fc44de76 (acpi: move aml builder code for i8042 
(kbd+mouse) device)
12/16 Checking commit d8ccc6f08dcd (acpi: factor out fw_cfg_add_acpi_dsdt())
13/16 Checking commit 4a8ceb8d9dd9 (acpi: simplify build_isa_devices_aml())
14/16 Checking commit 6324bbac2984 (acpi: drop serial/parallel enable bits from 
dsdt)
15/16 Checking commit 646a108f5ece (acpi: drop build_piix4_pm())
16/16 Checking commit 9adb28d40ad3 (acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden