[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 3/3] qemu-options: updates for abstract unix sockets
From: |
Eric Blake |
Subject: |
Re: [PATCH v4 3/3] qemu-options: updates for abstract unix sockets |
Date: |
Fri, 15 May 2020 12:37:39 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/14/20 11:32 PM, xiaoqiang zhao wrote:
add options documents changes for -chardev
Signed-off-by: xiaoqiang zhao <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
---
qemu-options.hx | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
I'd suggest listing 'abstract' before 'tight', since 'tight' only
matters for abstract. I also have grammar suggestions:
- ``unix options: path=path``
+ ``unix options: path=path[,tight=on|off][,abstract=on|off]``
``path`` specifies the local path of the unix socket. ``path``
is required.
+ ``tight`` whether to set @addrlen to the minimal string length,
+ or the maximum sun_path length. defaults to true. ``tight`` is
+ optional.
+ ``abstract`` whether use abstract address. defaults to false.
+ ``abstract`` is optional.
``abstract`` specifies the use of the abstract socket namespace, rather
than the filesystem. Optional, defaults to false.
``tight`` sets the socket length of abstract sockets to their minimum,
rather than the full sun_path length. Optional, defaults to true.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org