[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 1/9] tests/vm: Add configuration to basevm.py
From: |
Alex Bennée |
Subject: |
Re: [PATCH v6 1/9] tests/vm: Add configuration to basevm.py |
Date: |
Fri, 15 May 2020 18:23:06 +0100 |
User-agent: |
mu4e 1.4.5; emacs 28.0.50 |
Robert Foley <address@hidden> writes:
> Added use of a configuration to tests/vm/basevm.py.
> The configuration provides parameters used to configure a VM.
> This allows for providing alternate configurations to the VM being
> created/launched. cpu, machine, memory, and NUMA configuration are all
> examples of configuration which we might want to vary on the VM being created
> or launched.
> This will for example allow for creating an aarch64 vm.
>
> Signed-off-by: Robert Foley <address@hidden>
> Reviewed-by: Peter Puhov <address@hidden>
<snip>
> @@ -61,19 +86,30 @@ class BaseVM(object):
> # 4 is arbitrary, but greater than 2,
> # since we found we need to wait more than twice as long.
> tcg_ssh_timeout_multiplier = 4
> - def __init__(self, debug=False, vcpus=None):
> + def __init__(self, debug=False, vcpus=None, config=None):
> self._guest = None
<snip>
> else logging.WARN))
> - vm = vmcls(debug=args.debug, vcpus=args.jobs)
> + vm = vmcls(debug=args.debug, vcpus=args.jobs, config=config)
Given the number of times I've just had to fix merge failures with the
patches I've just sent I wonder if we should just pass args as a while
to vmcls and be done with it?
> if args.build_image:
> if os.path.exists(args.image) and not args.force:
> sys.stderr.writelines(["Image file exists: %s\n" %
> args.image,
--
Alex Bennée
- [PATCH v6 0/9] tests/vm: Add support for aarch64 VMs, Robert Foley, 2020/05/12
- [PATCH v6 1/9] tests/vm: Add configuration to basevm.py, Robert Foley, 2020/05/12
- Re: [PATCH v6 1/9] tests/vm: Add configuration to basevm.py,
Alex Bennée <=
- [PATCH v6 2/9] tests/vm: Added configuration file support, Robert Foley, 2020/05/12
- [PATCH v6 3/9] tests/vm: Pass --debug through for vm-boot-ssh., Robert Foley, 2020/05/12
- [PATCH v6 4/9] tests/vm: Add ability to select QEMU from current build., Robert Foley, 2020/05/12
- [PATCH v6 5/9] tests/vm: allow wait_ssh() to specify command, Robert Foley, 2020/05/12
- [PATCH v6 6/9] tests/vm: Added a new script for ubuntu.aarch64., Robert Foley, 2020/05/12
- [PATCH v6 7/9] tests/vm: Added a new script for centos.aarch64., Robert Foley, 2020/05/12
- [PATCH v6 8/9] tests/vm: change scripts to use self._config, Robert Foley, 2020/05/12