[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 02/16] acpi: move aml builder code for rtc device
From: |
Gerd Hoffmann |
Subject: |
[PATCH v6 02/16] acpi: move aml builder code for rtc device |
Date: |
Fri, 15 May 2020 17:04:07 +0200 |
Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/i386/acpi-build.c | 17 -----------------
hw/rtc/mc146818rtc.c | 22 ++++++++++++++++++++++
2 files changed, 22 insertions(+), 17 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 2e15f6848e7e..0bfa2dd23fcc 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1137,22 +1137,6 @@ static Aml *build_fdc_device_aml(ISADevice *fdc)
return dev;
}
-static Aml *build_rtc_device_aml(void)
-{
- Aml *dev;
- Aml *crs;
-
- dev = aml_device("RTC");
- aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0B00")));
- crs = aml_resource_template();
- aml_append(crs, aml_io(AML_DECODE16, 0x0070, 0x0070, 0x10, 0x02));
- aml_append(crs, aml_irq_no_flags(8));
- aml_append(crs, aml_io(AML_DECODE16, 0x0072, 0x0072, 0x02, 0x06));
- aml_append(dev, aml_name_decl("_CRS", crs));
-
- return dev;
-}
-
static Aml *build_kbd_device_aml(void)
{
Aml *dev;
@@ -1278,7 +1262,6 @@ static void build_isa_devices_aml(Aml *table)
Aml *scope = aml_scope("_SB.PCI0.ISA");
Object *obj = object_resolve_path_type("", TYPE_ISA_BUS, &ambiguous);
- aml_append(scope, build_rtc_device_aml());
aml_append(scope, build_kbd_device_aml());
aml_append(scope, build_mouse_device_aml());
if (fdc) {
diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c
index 9c30cbdcd76f..fe05a4488e43 100644
--- a/hw/rtc/mc146818rtc.c
+++ b/hw/rtc/mc146818rtc.c
@@ -27,6 +27,7 @@
#include "qemu/cutils.h"
#include "qemu/module.h"
#include "qemu/bcd.h"
+#include "hw/acpi/aml-build.h"
#include "hw/irq.h"
#include "hw/qdev-properties.h"
#include "qemu/timer.h"
@@ -1007,13 +1008,34 @@ static void rtc_resetdev(DeviceState *d)
}
}
+static void rtc_build_aml(ISADevice *isadev, Aml *scope)
+{
+ Aml *dev;
+ Aml *crs;
+
+ crs = aml_resource_template();
+ aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE,
+ 0x10, 0x02));
+ aml_append(crs, aml_irq_no_flags(RTC_ISA_IRQ));
+ aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE + 2, RTC_ISA_BASE + 2,
+ 0x02, 0x06));
+
+ dev = aml_device("RTC");
+ aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0B00")));
+ aml_append(dev, aml_name_decl("_CRS", crs));
+
+ aml_append(scope, dev);
+}
+
static void rtc_class_initfn(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
+ ISADeviceClass *isa = ISA_DEVICE_CLASS(klass);
dc->realize = rtc_realizefn;
dc->reset = rtc_resetdev;
dc->vmsd = &vmstate_rtc;
+ isa->build_aml = rtc_build_aml;
device_class_set_props(dc, mc146818rtc_properties);
}
--
2.18.4
- [PATCH v6 00/16] acpi: i386 tweaks, Gerd Hoffmann, 2020/05/15
- [PATCH v6 04/16] acpi: serial: don't use _STA method, Gerd Hoffmann, 2020/05/15
- [PATCH v6 01/16] qtest: allow DSDT acpi table changes, Gerd Hoffmann, 2020/05/15
- [PATCH v6 13/16] acpi: simplify build_isa_devices_aml(), Gerd Hoffmann, 2020/05/15
- [PATCH v6 05/16] acpi: move aml builder code for serial device, Gerd Hoffmann, 2020/05/15
- [PATCH v6 03/16] acpi: rtc: use a single crs range, Gerd Hoffmann, 2020/05/15
- [PATCH v6 14/16] acpi: drop serial/parallel enable bits from dsdt, Gerd Hoffmann, 2020/05/15
- [PATCH v6 02/16] acpi: move aml builder code for rtc device,
Gerd Hoffmann <=
- [PATCH v6 10/16] floppy: move cmos_get_fd_drive_type() from pc, Gerd Hoffmann, 2020/05/15
- [PATCH v6 12/16] acpi: factor out fw_cfg_add_acpi_dsdt(), Gerd Hoffmann, 2020/05/15
- [PATCH v6 06/16] acpi: parallel: don't use _STA method, Gerd Hoffmann, 2020/05/15
- [PATCH v6 16/16] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion., Gerd Hoffmann, 2020/05/15
- [PATCH v6 07/16] acpi: move aml builder code for parallel device, Gerd Hoffmann, 2020/05/15
- [PATCH v6 15/16] acpi: drop build_piix4_pm(), Gerd Hoffmann, 2020/05/15