[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 03/16] acpi: rtc: use a single crs range
From: |
Gerd Hoffmann |
Subject: |
[PATCH v6 03/16] acpi: rtc: use a single crs range |
Date: |
Fri, 15 May 2020 17:04:08 +0200 |
Use a single io range for _CRS instead of two,
following what real hardware does.
Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
---
hw/rtc/mc146818rtc.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c
index fe05a4488e43..1e9fa0f33fed 100644
--- a/hw/rtc/mc146818rtc.c
+++ b/hw/rtc/mc146818rtc.c
@@ -1013,12 +1013,14 @@ static void rtc_build_aml(ISADevice *isadev, Aml *scope)
Aml *dev;
Aml *crs;
+ /*
+ * Reserving 8 io ports here, following what physical hardware
+ * does, even though qemu only responds to the first two ports.
+ */
crs = aml_resource_template();
aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE,
- 0x10, 0x02));
+ 0x01, 0x08));
aml_append(crs, aml_irq_no_flags(RTC_ISA_IRQ));
- aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE + 2, RTC_ISA_BASE + 2,
- 0x02, 0x06));
dev = aml_device("RTC");
aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0B00")));
--
2.18.4
- [PATCH v6 00/16] acpi: i386 tweaks, Gerd Hoffmann, 2020/05/15
- [PATCH v6 04/16] acpi: serial: don't use _STA method, Gerd Hoffmann, 2020/05/15
- [PATCH v6 01/16] qtest: allow DSDT acpi table changes, Gerd Hoffmann, 2020/05/15
- [PATCH v6 13/16] acpi: simplify build_isa_devices_aml(), Gerd Hoffmann, 2020/05/15
- [PATCH v6 05/16] acpi: move aml builder code for serial device, Gerd Hoffmann, 2020/05/15
- [PATCH v6 03/16] acpi: rtc: use a single crs range,
Gerd Hoffmann <=
- [PATCH v6 14/16] acpi: drop serial/parallel enable bits from dsdt, Gerd Hoffmann, 2020/05/15
- [PATCH v6 02/16] acpi: move aml builder code for rtc device, Gerd Hoffmann, 2020/05/15
- [PATCH v6 10/16] floppy: move cmos_get_fd_drive_type() from pc, Gerd Hoffmann, 2020/05/15
- [PATCH v6 12/16] acpi: factor out fw_cfg_add_acpi_dsdt(), Gerd Hoffmann, 2020/05/15
- [PATCH v6 06/16] acpi: parallel: don't use _STA method, Gerd Hoffmann, 2020/05/15
- [PATCH v6 16/16] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion., Gerd Hoffmann, 2020/05/15