qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/10] ui/gtk: use native keyboard scancodes on Windows


From: Volker Rümelin
Subject: Re: [PATCH 10/10] ui/gtk: use native keyboard scancodes on Windows
Date: Thu, 14 May 2020 22:46:41 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

> since that time, we no longer support Debian Jessie, since Debian Buster
> is now released. We also no longer support Ubuntu Xenial (16.04), since
> we now only need Ubuntu Bionic (18.04) and Focal (20.04).
>
> So we can justify moving the minium Gtk in QEMU to 3.22 at this time.
>
> This will avoid you needing to do versioned ifdef for this new functionality.

Hi Daniel,

I noticed there are already seven versioned ifdefs in ui/gtk.c. I would prefer 
to leave my patch as it is at the moment and send in a separate follow up patch 
which increases the minimum GTK version in configure to 3.22 and removes all 
versioned code in ui/gtk.c. Just like your patch from 2018. I think this is 
easier to revert if someone complains about the removal.

With best regards,
Volker



reply via email to

[Prev in Thread] Current Thread [Next in Thread]