[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
答复: [PATCH 5/6] migration/qemu-file.c: Don't ratelimit a shutdown fd
|
From: |
Zhanghailiang |
|
Subject: |
答复: [PATCH 5/6] migration/qemu-file.c: Don't ratelimit a shutdown fd |
|
Date: |
Thu, 14 May 2020 13:05:00 +0000 |
> This causes the migration thread to hang if we failover during checkpoint. A
> shutdown fd won't cause network traffic anyway.
>
I'm not quite sure if this modification can take side effect on normal
migration process or not,
There are several places calling it.
Maybe Juan and Dave can help ;)
> Signed-off-by: Lukas Straub <address@hidden>
> ---
> migration/qemu-file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/qemu-file.c b/migration/qemu-file.c index
> 1c3a358a14..0748b5810f 100644
> --- a/migration/qemu-file.c
> +++ b/migration/qemu-file.c
> @@ -660,7 +660,7 @@ int64_t qemu_ftell(QEMUFile *f) int
> qemu_file_rate_limit(QEMUFile *f) {
> if (f->shutdown) {
> - return 1;
> + return 0;
> }
> if (qemu_file_get_error(f)) {
> return 1;
> --
> 2.20.1
- [PATCH 1/6] migration/colo.c: Use event instead of semaphore, (continued)
- [PATCH 1/6] migration/colo.c: Use event instead of semaphore, Lukas Straub, 2020/05/11
- [PATCH 2/6] migration/colo.c: Use cpu_synchronize_all_states(), Lukas Straub, 2020/05/11
- [PATCH 3/6] migration/colo.c: Flush ram cache only after receiving device state, Lukas Straub, 2020/05/11
- [PATCH 4/6] migration/colo.c: Relaunch failover even if there was an error, Lukas Straub, 2020/05/11
- [PATCH 5/6] migration/qemu-file.c: Don't ratelimit a shutdown fd, Lukas Straub, 2020/05/11
- 答复: [PATCH 5/6] migration/qemu-file.c: Don't ratelimit a shutdown fd,
Zhanghailiang <=
[PATCH 6/6] migration/colo.c: Move colo_notify_compares_event to the right place, Lukas Straub, 2020/05/11
RE: [PATCH 6/6] migration/colo.c: Move colo_notify_compares_event to the right place, Zhanghailiang, 2020/05/14