[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part
From: |
Igor Mammedov |
Subject: |
Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part |
Date: |
Thu, 14 May 2020 11:53:04 +0200 |
On Tue, 12 May 2020 17:59:25 +0200
Auger Eric <address@hidden> wrote:
> Hi Igor,
>
> On 5/12/20 4:14 PM, Igor Mammedov wrote:
> > On Wed, 6 May 2020 05:58:25 -0400
> > "Michael S. Tsirkin" <address@hidden> wrote:
> >
> >> On Wed, May 06, 2020 at 08:33:14AM +0200, Andrew Jones wrote:
> >>> I realize this function is just getting moved, but maybe it should get
> >>> converted to the build_append* API while being moved?
> >>
> >> I'd rather refactoring was done in a separate patch -
> >> easier to review.
> > maybe first convert and then move
> >
> > PS:
> > me wonders if we have test with TPM enabled, if not maybe it's time to add
> > them
> > i.e. first goes testcase in bios-tables and then refactoring/moving
> > in that case review is simpler.
> Do you mean tests checking the ACPI table content when TPM is
> instantiated? I don't think so otherwise it would have failed I guess.
yes, I've meant that.
> Otherwise we have functional tests with TPM (MMIO access), ie qtest
> tests tpm-tis-device-test and tpm-tis-device-swtpm-test.
>
> Thanks
>
> Eric
> >
> >
[PATCH v2 2/3] arm/acpi: TPM2 ACPI table support, Eric Auger, 2020/05/05
[PATCH v2 3/3] arm/acpi: Add the TPM2.0 device under the DSDT, Eric Auger, 2020/05/05
Re: [PATCH v2 3/3] arm/acpi: Add the TPM2.0 device under the DSDT, Igor Mammedov, 2020/05/12
Re: [PATCH v2 0/3] vTPM/aarch64 ACPI support, Ard Biesheuvel, 2020/05/05