[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/6] target/ppc: Pass const pointer to ppc_radix64_get_ful
From: |
Cédric Le Goater |
Subject: |
Re: [PATCH v2 2/6] target/ppc: Pass const pointer to ppc_radix64_get_fully_qualified_addr() |
Date: |
Thu, 14 May 2020 08:29:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/14/20 12:56 AM, Greg Kurz wrote:
> This doesn't require write access to the CPU registers.
>
> Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
> ---
> target/ppc/mmu-radix64.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
> index 1404e53deca8..c76879f65b78 100644
> --- a/target/ppc/mmu-radix64.c
> +++ b/target/ppc/mmu-radix64.c
> @@ -28,7 +28,8 @@
> #include "mmu-radix64.h"
> #include "mmu-book3s-v3.h"
>
> -static bool ppc_radix64_get_fully_qualified_addr(CPUPPCState *env, vaddr
> eaddr,
> +static bool ppc_radix64_get_fully_qualified_addr(const CPUPPCState *env,
> + vaddr eaddr,
> uint64_t *lpid, uint64_t
> *pid)
> {
> if (msr_hv) { /* MSR[HV] -> Hypervisor/bare metal */
>
- [PATCH v2 0/6] target/ppc: Various clean-up and fixes for radix64, Greg Kurz, 2020/05/13
- [PATCH v2 1/6] target/ppc: Pass const pointer to ppc_radix64_get_prot_amr(), Greg Kurz, 2020/05/13
- [PATCH v2 2/6] target/ppc: Pass const pointer to ppc_radix64_get_fully_qualified_addr(), Greg Kurz, 2020/05/13
- Re: [PATCH v2 2/6] target/ppc: Pass const pointer to ppc_radix64_get_fully_qualified_addr(),
Cédric Le Goater <=
- [PATCH v2 3/6] target/ppc: Don't initialize some local variables in ppc_radix64_xlate(), Greg Kurz, 2020/05/13
- [PATCH v2 5/6] target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate(), Greg Kurz, 2020/05/13
- [PATCH v2 4/6] target/ppc: Add missing braces in ppc_radix64_partition_scoped_xlate(), Greg Kurz, 2020/05/13
- [PATCH v2 6/6] target/ppc: Don't update radix PTE R/C bits with gdbstub, Greg Kurz, 2020/05/13
- Re: [PATCH v2 0/6] target/ppc: Various clean-up and fixes for radix64, David Gibson, 2020/05/14