Re: [PATCH v3 11/16] target/arm: Remove fp_status from helper_{recpe, rsqrte}_u32

[Peter Maydell]

On Fri, 8 May 2020 at 16:22, Richard Henderson
<address@hidden> wrote:
>
> These operations do not touch fp_status.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---

> diff --git a/target/arm/vfp_helper.c b/target/arm/vfp_helper.c
> index 930d6e747f..a792661166 100644
> --- a/target/arm/vfp_helper.c
> +++ b/target/arm/vfp_helper.c
> @@ -1023,7 +1023,7 @@ float64 HELPER(rsqrte_f64)(float64 input, void *fpstp)
>      return make_float64(val);
>  }
>
> -uint32_t HELPER(recpe_u32)(uint32_t a, void *fpstp)
> +uint32_t HELPER(recpe_u32)(uint32_t a)
>  {
>      /* float_status *s = fpstp; */

We should delete this stale commented out line of code too.

>      int input, estimate;
> @@ -1038,7 +1038,7 @@ uint32_t HELPER(recpe_u32)(uint32_t a, void *fpstp)
>      return deposit32(0, (32 - 9), 9, estimate);
>  }
>
> -uint32_t HELPER(rsqrte_u32)(uint32_t a, void *fpstp)
> +uint32_t HELPER(rsqrte_u32)(uint32_t a)
>  {
>      int estimate;

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM