qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 3/9] block: Make it easier to learn which BDS support bitm


From: Eric Blake
Subject: Re: [PATCH v3 3/9] block: Make it easier to learn which BDS support bitmaps
Date: Mon, 11 May 2020 16:21:14 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0

On 5/11/20 1:16 PM, Eric Blake wrote:
On 5/11/20 4:21 AM, Max Reitz wrote:

+++ b/include/block/block_int.h
@@ -560,6 +560,7 @@ struct BlockDriver {
                               uint64_t parent_perm, uint64_t parent_shared,
                               uint64_t *nperm, uint64_t *nshared);

+    bool (*bdrv_dirty_bitmap_supported)(BlockDriverState *bs);

All BDSs support bitmaps, but only some support persistent dirty
bitmaps, so I think the name should reflect that.

How about .bdrv_dirty_bitmap_supports_persistent?

Bike-shedding myself, it looks like .bdrv_supports_persistent_dirty_bitmap is better (if you go by the naming convention 'noun-verb-details', it makes more sense that a 'bdrv' supports 'persistent dirty bitmaps', than that a 'bdrv dirty bitmap' supports 'persistence', particularly when the parameter is a BlockDriverState rather than a BdrvDirtyBitmap).

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]