[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 17/74] hw/semihosting: convert to cpu_halted_set
From: |
Alex Bennée |
Subject: |
Re: [PATCH v8 17/74] hw/semihosting: convert to cpu_halted_set |
Date: |
Mon, 11 May 2020 11:25:53 +0100 |
User-agent: |
mu4e 1.4.5; emacs 28.0.50 |
Robert Foley <address@hidden> writes:
> Signed-off-by: Robert Foley <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> hw/semihosting/console.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c
> index 6346bd7f50..f70085f3c1 100644
> --- a/hw/semihosting/console.c
> +++ b/hw/semihosting/console.c
> @@ -131,7 +131,7 @@ static void console_wake_up(gpointer data, gpointer
> user_data)
> {
> CPUState *cs = (CPUState *) data;
> /* cpu_handle_halt won't know we have work so just unbung here */
> - cs->halted = 0;
> + cpu_halted_set(cs, 0);
> qemu_cpu_kick(cs);
> }
>
> @@ -154,7 +154,7 @@ target_ulong qemu_semihosting_console_inc(CPUArchState
> *env)
> g_assert(current_cpu);
> if (fifo8_is_empty(&c->fifo)) {
> c->sleeping_cpus = g_slist_prepend(c->sleeping_cpus, current_cpu);
> - current_cpu->halted = 1;
> + cpu_halted_set(current_cpu, 1);
> current_cpu->exception_index = EXCP_HALTED;
> cpu_loop_exit(current_cpu);
> /* never returns */
--
Alex Bennée
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v8 17/74] hw/semihosting: convert to cpu_halted_set,
Alex Bennée <=