[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/acceptance/boot_linux: Skip slow Aarch64 'virt' machin
From: |
Lukas Straub |
Subject: |
Re: [PATCH] tests/acceptance/boot_linux: Skip slow Aarch64 'virt' machine TCG test |
Date: |
Sat, 9 May 2020 15:18:01 +0200 |
On Thu, 7 May 2020 18:22:35 +0200
Philippe Mathieu-Daudé <address@hidden> wrote:
> The BootLinuxAarch64.test_virt_tcg is reported to take >7min to run.
> Add a possibility to users to skip this particular test, by setting
> the AVOCADO_SKIP_SLOW_TESTS environment variable:
>
> $ AVOCADO_SKIP_SLOW_TESTS=please make check-acceptance
> ...
> (05/88) tests/acceptance/boot_linux.py:BootLinuxAarch64.test_virt_tcg:
> SKIP: Test takes >7min
> ...
>
> Reported-by: Peter Maydell <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/acceptance/boot_linux.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/acceptance/boot_linux.py b/tests/acceptance/boot_linux.py
> index 075a386300..a8df50d769 100644
> --- a/tests/acceptance/boot_linux.py
> +++ b/tests/acceptance/boot_linux.py
> @@ -15,6 +15,7 @@
> from qemu.accel import kvm_available
> from qemu.accel import tcg_available
>
> +from avocado import skipIf
> from avocado.utils import cloudinit
> from avocado.utils import network
> from avocado.utils import vmimage
> @@ -159,6 +160,7 @@ def add_common_args(self):
> self.vm.add_args('-device', 'virtio-rng-pci,rng=rng0')
> self.vm.add_args('-object',
> 'rng-random,id=rng0,filename=/dev/urandom')
>
> + @skipIf(os.getenv('AVOCADO_SKIP_SLOW_TESTS'), 'Test takes >7min')
> def test_virt_tcg(self):
> """
> :avocado: tags=accel:tcg
Hi,
Why not simply add slow tag to the test. Like:
:avocado: tags=slow
The slow tests can then be skipped with
$ make check-acceptance AVOCADO_TAGS='-t -slow'
Regards,
Lukas Straub
pgpC75svNPb0w.pgp
Description: OpenPGP digital signature