[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated d
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic |
|
Date: |
Fri, 8 May 2020 17:33:42 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 08/05/20 17:20, Beata Michalska wrote:
>>
>> mr->dirty_log_mask tells if dirty tracking has been enabled, not if the
>> page is dirty. It would always be true during live migration and when
>> running on TCG, but otherwise it would always be false.
>>
>> Beata, can you explain what you had in mind? :)
>>
> It has been a while ... , but the intention there was to skip the sync
> if there is nothing to be synced in the first place - so for performance
> reasons. I honestly do not recall why I went for the dirty_log_mask,
> as that seems not to be the right choice .
You probably wanted to look at the dirty bitmap, but you would have to
define a new bitmap rather than looking at dirty_log_mask.
But that's cool, because it means that we can just remove it! Thanks,
Paolo
- [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic, Philippe Mathieu-Daudé, 2020/05/08
- [PATCH 1/4] memory: Rename memory_region_do_writeback -> memory_region_writeback, Philippe Mathieu-Daudé, 2020/05/08
- [PATCH 2/4] memory: Extract memory_region_msync() from memory_region_writeback(), Philippe Mathieu-Daudé, 2020/05/08
- [PATCH 3/4] hw/block: Let the NVMe emulated device be target-agnostic, Philippe Mathieu-Daudé, 2020/05/08
- [PATCH 4/4] exec: Rename qemu_ram_writeback() as qemu_ram_msync(), Philippe Mathieu-Daudé, 2020/05/08
- Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic, Paolo Bonzini, 2020/05/08
Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic, Stefan Hajnoczi, 2020/05/21
Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic, Stefan Hajnoczi, 2020/05/27