[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/5] virtio-iommu: Handle reserved regions in the translation
From: |
Peter Xu |
Subject: |
Re: [PATCH 3/5] virtio-iommu: Handle reserved regions in the translation process |
Date: |
Thu, 7 May 2020 15:47:36 -0400 |
Hi, Eric,
On Thu, May 07, 2020 at 04:31:59PM +0200, Eric Auger wrote:
> @@ -640,6 +641,24 @@ static IOMMUTLBEntry
> virtio_iommu_translate(IOMMUMemoryRegion *mr, hwaddr addr,
> goto unlock;
> }
>
> + for (i = 0; i < s->nb_reserved_regions; i++) {
> + if (interval.low >= s->reserved_regions[i].low &&
> + interval.low <= s->reserved_regions[i].high) {
Should this be s/low/high/?
For this case (high==low+1) I guess maybe it's also easier to use "addr >= low
&& addr < high".
Thanks,
> + switch (s->reserved_regions[i].type) {
> + case VIRTIO_IOMMU_RESV_MEM_T_MSI:
> + entry.perm = flag;
> + break;
> + case VIRTIO_IOMMU_RESV_MEM_T_RESERVED:
> + default:
> + virtio_iommu_report_fault(s, VIRTIO_IOMMU_FAULT_R_MAPPING,
> + VIRTIO_IOMMU_FAULT_F_ADDRESS,
> + sid, addr);
> + break;
> + }
> + goto unlock;
> + }
> + }
> +
> if (!ep->domain) {
> if (!bypass_allowed) {
> error_report_once("%s %02x:%02x.%01x not attached to any domain",
> --
> 2.20.1
>
--
Peter Xu
- [PATCH 0/5] VIRTIO-IOMMU probe request support and MSI bypass on ARM, Eric Auger, 2020/05/07
- [PATCH 1/5] qdev: Introduce DEFINE_PROP_RESERVED_REGION, Eric Auger, 2020/05/07
- [PATCH 3/5] virtio-iommu: Handle reserved regions in the translation process, Eric Auger, 2020/05/07
- Re: [PATCH 3/5] virtio-iommu: Handle reserved regions in the translation process,
Peter Xu <=
- [PATCH 2/5] virtio-iommu: Implement RESV_MEM probe request, Eric Auger, 2020/05/07
- [PATCH 4/5] virtio-iommu-pci: Add array of Interval properties, Eric Auger, 2020/05/07
- [PATCH 5/5] hw/arm/virt: Let the virtio-iommu bypass MSIs, Eric Auger, 2020/05/07