[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 04/10] target/arm: Use tcg_gen_gvec_dup_imm
From: |
Richard Henderson |
Subject: |
Re: [PULL 04/10] target/arm: Use tcg_gen_gvec_dup_imm |
Date: |
Thu, 7 May 2020 10:16:41 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/7/20 7:39 AM, Laurent Desnogues wrote:
>> @@ -2044,7 +2044,7 @@ static bool trans_DUP_x(DisasContext *s, arg_DUP_x *a)
>> unsigned nofs = vec_reg_offset(s, a->rn, index, esz);
>> tcg_gen_gvec_dup_mem(esz, dofs, nofs, vsz, vsz);
>> } else {
>> - tcg_gen_gvec_dup64i(dofs, vsz, vsz, 0);
>> + tcg_gen_gvec_dup_imm(esz, dofs, vsz, vsz, 0);
>
> For an indexed DUP, size can be 128-bit so that will fail the first
> assert in tcg-op-gvec.c:do_dup.
Ho hum, quite right. This has already been merged, so I'll send a follow-up
fix.
r~
- [PULL 00/10] tcg patch queue, Richard Henderson, 2020/05/06
- [PULL 01/10] tcg: Add tcg_gen_gvec_dup_imm, Richard Henderson, 2020/05/06
- [PULL 02/10] target/s390x: Use tcg_gen_gvec_dup_imm, Richard Henderson, 2020/05/06
- [PULL 03/10] target/ppc: Use tcg_gen_gvec_dup_imm, Richard Henderson, 2020/05/06
- [PULL 04/10] target/arm: Use tcg_gen_gvec_dup_imm, Richard Henderson, 2020/05/06
- [PULL 05/10] tcg: Use tcg_gen_gvec_dup_imm in logical simplifications, Richard Henderson, 2020/05/06
- [PULL 06/10] tcg: Remove tcg_gen_gvec_dup{8,16,32,64}i, Richard Henderson, 2020/05/06
- [PULL 07/10] tcg: Add tcg_gen_gvec_dup_tl, Richard Henderson, 2020/05/06
- [PULL 08/10] tcg: Improve vector tail clearing, Richard Henderson, 2020/05/06
- [PULL 09/10] tcg: Add load_dest parameter to GVecGen2, Richard Henderson, 2020/05/06
- [PULL 10/10] tcg: Fix integral argument type to tcg_gen_rot[rl]i_i{32, 64}, Richard Henderson, 2020/05/06
- Re: [PULL 00/10] tcg patch queue, Peter Maydell, 2020/05/07