Re: [PULL 04/10] target/arm: Use tcg_gen_gvec_dup_imm

[Richard Henderson]

On 5/7/20 7:39 AM, Laurent Desnogues wrote:
>> @@ -2044,7 +2044,7 @@ static bool trans_DUP_x(DisasContext *s, arg_DUP_x *a)
>>              unsigned nofs = vec_reg_offset(s, a->rn, index, esz);
>>              tcg_gen_gvec_dup_mem(esz, dofs, nofs, vsz, vsz);
>>          } else {
>> -            tcg_gen_gvec_dup64i(dofs, vsz, vsz, 0);
>> +            tcg_gen_gvec_dup_imm(esz, dofs, vsz, vsz, 0);
> 
> For an indexed DUP, size can be 128-bit so that will fail the first
> assert in tcg-op-gvec.c:do_dup.

Ho hum, quite right.  This has already been merged, so I'll send a follow-up 
fix.


r~