[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 09/12] migration/rdma: fix a memleak on error path in rdma_start_i
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[PULL 09/12] migration/rdma: fix a memleak on error path in rdma_start_incoming_migration |
Date: |
Thu, 7 May 2020 18:02:08 +0100 |
From: Pan Nengyuan <address@hidden>
'rdma->host' is malloced in qemu_rdma_data_init, but forgot to free on the error
path in rdma_start_incoming_migration(), this patch fix that.
The leak stack:
Direct leak of 2 byte(s) in 1 object(s) allocated from:
#0 0x7fb7add18ae8 in __interceptor_malloc (/lib64/libasan.so.5+0xefae8)
#1 0x7fb7ad0df1d5 in g_malloc (/lib64/libglib-2.0.so.0+0x531d5)
#2 0x7fb7ad0f8b32 in g_strdup (/lib64/libglib-2.0.so.0+0x6cb32)
#3 0x55a0464a0f6f in qemu_rdma_data_init /mnt/sdb/qemu/migration/rdma.c:2647
#4 0x55a0464b0e76 in rdma_start_incoming_migration
/mnt/sdb/qemu/migration/rdma.c:4020
#5 0x55a0463f898a in qemu_start_incoming_migration
/mnt/sdb/qemu/migration/migration.c:365
#6 0x55a0458c75d3 in qemu_init /mnt/sdb/qemu/softmmu/vl.c:4438
#7 0x55a046a3d811 in main /mnt/sdb/qemu/softmmu/main.c:48
#8 0x7fb7a8417872 in __libc_start_main (/lib64/libc.so.6+0x23872)
#9 0x55a04536b26d in _start
(/mnt/sdb/qemu/build/x86_64-softmmu/qemu-system-x86_64+0x286926d)
Reported-by: Euler Robot <address@hidden>
Signed-off-by: Pan Nengyuan <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
migration/rdma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/rdma.c b/migration/rdma.c
index f61587891b..967fda5b0c 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -4056,6 +4056,7 @@ void rdma_start_incoming_migration(const char *host_port,
Error **errp)
return;
err:
error_propagate(errp, local_err);
+ g_free(rdma->host);
g_free(rdma);
g_free(rdma_return_path);
}
--
2.26.2
- [PULL 00/12] migration queue, Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 03/12] monitor/hmp-cmds: add hmp_handle_error() for hmp_migrate_set_speed(), Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 04/12] migration: move the units of migrate parameters from milliseconds to ms, Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 01/12] migration: fix bad indentation in error_report(), Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 02/12] migration/migration: improve error reporting for migrate parameters, Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 06/12] migration/colo: Add missing error-propagation code, Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 05/12] docs/devel/migration: start a debugging section, Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 07/12] migration/throttle: Add cpu-throttle-tailslow migration parameter, Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 08/12] migration/ram: Consolidate variable reset after placement in ram_load_postcopy(), Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 09/12] migration/rdma: fix a memleak on error path in rdma_start_incoming_migration,
Dr. David Alan Gilbert (git) <=
- [PULL 10/12] migration/xbzrle: add encoding rate, Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 11/12] migration/multifd: fix memleaks in multifd_new_send_channel_async, Dr. David Alan Gilbert (git), 2020/05/07
- [PULL 12/12] migration/multifd: Do error_free after migrate_set_error to avoid memleaks, Dr. David Alan Gilbert (git), 2020/05/07
- Re: [PULL 00/12] migration queue, Peter Maydell, 2020/05/07