[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 11/15] acpi: simplify build_isa_devices_aml()
From: |
Gerd Hoffmann |
Subject: |
[PATCH v5 11/15] acpi: simplify build_isa_devices_aml() |
Date: |
Thu, 7 May 2020 15:16:36 +0200 |
x86 machines can have a single ISA bus only.
Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/i386/acpi-build.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index cb3913d2ee76..1922868f3401 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1061,19 +1061,14 @@ static void build_hpet_aml(Aml *table)
static void build_isa_devices_aml(Aml *table)
{
bool ambiguous;
-
- Aml *scope = aml_scope("_SB.PCI0.ISA");
Object *obj = object_resolve_path_type("", TYPE_ISA_BUS, &ambiguous);
+ Aml *scope;
- if (ambiguous) {
- error_report("Multiple ISA busses, unable to define IPMI ACPI data");
- } else if (!obj) {
- error_report("No ISA bus, unable to define IPMI ACPI data");
- } else {
- build_acpi_ipmi_devices(scope, BUS(obj), "\\_SB.PCI0.ISA");
- isa_build_aml(ISA_BUS(obj), scope);
- }
+ assert(obj && !ambiguous);
+ scope = aml_scope("_SB.PCI0.ISA");
+ build_acpi_ipmi_devices(scope, BUS(obj), "\\_SB.PCI0.ISA");
+ isa_build_aml(ISA_BUS(obj), scope);
aml_append(table, scope);
}
--
2.18.4
- [PATCH v5 13/15] acpi: drop build_piix4_pm(), (continued)
- [PATCH v5 14/15] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion., Gerd Hoffmann, 2020/05/07
- [PATCH v5 12/15] acpi: drop serial/parallel enable bits from dsdt, Gerd Hoffmann, 2020/05/07
- [PATCH v5 07/15] acpi: move aml builder code for parallel device, Gerd Hoffmann, 2020/05/07
- [PATCH v5 11/15] acpi: simplify build_isa_devices_aml(),
Gerd Hoffmann <=
- [PATCH v5 15/15] floppy: make isa_fdc_get_drive_max_chs static, Gerd Hoffmann, 2020/05/07
- [PATCH v5 06/15] acpi: parallel: don't use _STA method, Gerd Hoffmann, 2020/05/07
- [PATCH v5 05/15] acpi: move aml builder code for serial device, Gerd Hoffmann, 2020/05/07