[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 09/14] tests/tcg: drop inferior.was_attached() test
From: |
Alex Bennée |
Subject: |
[PULL 09/14] tests/tcg: drop inferior.was_attached() test |
Date: |
Wed, 6 May 2020 13:05:24 +0100 |
This test seems flaky and reports attachment even when we failed to
negotiate the architecture. However the fetching of the guest
architecture will fail tripping up the gdb AttributeError which will
trigger our early no error status exit from the test
Signed-off-by: Alex Bennée <address@hidden>
Message-Id: <address@hidden>
diff --git a/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
b/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
index 387b2fc20aa..972cf73c315 100644
--- a/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
+++ b/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
@@ -58,9 +58,6 @@ def run_test():
#
try:
inferior = gdb.selected_inferior()
- if inferior.was_attached == False:
- print("SKIPPING (failed to attach)", file=sys.stderr)
- exit(0)
arch = inferior.architecture()
report(arch.name() == "aarch64", "connected to aarch64")
except (gdb.error, AttributeError):
diff --git a/tests/tcg/aarch64/gdbstub/test-sve.py
b/tests/tcg/aarch64/gdbstub/test-sve.py
index 5995689625e..b96bdbb99af 100644
--- a/tests/tcg/aarch64/gdbstub/test-sve.py
+++ b/tests/tcg/aarch64/gdbstub/test-sve.py
@@ -59,9 +59,6 @@ def run_test():
#
try:
inferior = gdb.selected_inferior()
- if inferior.was_attached == False:
- print("SKIPPING (failed to attach)", file=sys.stderr)
- exit(0)
arch = inferior.architecture()
report(arch.name() == "aarch64", "connected to aarch64")
except (gdb.error, AttributeError):
--
2.20.1
- [PULL 00/14] testing and gdbstub updates, Alex Bennée, 2020/05/06
- [PULL 02/14] .travis.yml: drop MacOSX, Alex Bennée, 2020/05/06
- [PULL 05/14] .travis.yml: reduce the load on [ppc64] GCC check-tcg, Alex Bennée, 2020/05/06
- [PULL 03/14] .cirrus.yml: bump FreeBSD to the current stable release, Alex Bennée, 2020/05/06
- [PULL 06/14] configure: favour gdb-multiarch if we have it, Alex Bennée, 2020/05/06
- [PULL 01/14] .travis.yml: show free disk space at end of run, Alex Bennée, 2020/05/06
- [PULL 04/14] .cirrus.yml: bootstrap pkg unconditionally, Alex Bennée, 2020/05/06
- [PULL 08/14] tests/tcg: better trap gdb failures, Alex Bennée, 2020/05/06
- [PULL 07/14] gdbstub: Introduce gdb_get_float64() to get 64-bit float registers, Alex Bennée, 2020/05/06
- [PULL 10/14] gdbstub: eliminate gdbserver_fd global, Alex Bennée, 2020/05/06
- [PULL 09/14] tests/tcg: drop inferior.was_attached() test,
Alex Bennée <=
- [PULL 11/14] gdbstub/linux-user: support debugging over a unix socket, Alex Bennée, 2020/05/06
- [PULL 12/14] tests/guest-debug: use the unix socket for linux-user tests, Alex Bennée, 2020/05/06
- [PULL 14/14] target/m68k: fix gdb for m68xxx, Alex Bennée, 2020/05/06
- [PULL 13/14] tests/tcg: add a multiarch linux-user gdb test, Alex Bennée, 2020/05/06
- Re: [PULL 00/14] testing and gdbstub updates, Peter Maydell, 2020/05/06