[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 11/31] qcow2: Add offset_into_subcluster() and size_to_sub
From: |
Alberto Garcia |
Subject: |
Re: [PATCH v5 11/31] qcow2: Add offset_into_subcluster() and size_to_subclusters() |
Date: |
Wed, 06 May 2020 12:18:28 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 05 May 2020 09:42:08 PM CEST, Eric Blake wrote:
> On 5/5/20 12:38 PM, Alberto Garcia wrote:
>> Like offset_into_cluster() and size_to_clusters(), but for
>> subclusters.
>>
>> Signed-off-by: Alberto Garcia <address@hidden>
>> ---
>> block/qcow2.h | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/block/qcow2.h b/block/qcow2.h
>> index e68febb15b..8b1ed1cbcf 100644
>> --- a/block/qcow2.h
>> +++ b/block/qcow2.h
>> @@ -537,11 +537,21 @@ static inline int64_t
>> offset_into_cluster(BDRVQcow2State *s, int64_t offset)
>> return offset & (s->cluster_size - 1);
>> }
>>
>> +static inline int64_t offset_into_subcluster(BDRVQcow2State *s, int64_t
>> offset)
>> +{
>> + return offset & (s->subcluster_size - 1);
>> +}
>> +
>> static inline uint64_t size_to_clusters(BDRVQcow2State *s, uint64_t size)
>> {
>> return (size + (s->cluster_size - 1)) >> s->cluster_bits;
>> }
>
> Pre-existing, but this could use DIV_ROUND_UP.
Yeah but it would be nicer to have a version of the macro optimized for
powers of two.
Berto
- [PATCH v5 00/31] Add subcluster allocation to qcow2, Alberto Garcia, 2020/05/05
- [PATCH v5 10/31] qcow2: Add offset_to_sc_index(), Alberto Garcia, 2020/05/05
- [PATCH v5 09/31] qcow2: Add subcluster-related fields to BDRVQcow2State, Alberto Garcia, 2020/05/05
- [PATCH v5 12/31] qcow2: Add l2_entry_size(), Alberto Garcia, 2020/05/05
- [PATCH v5 22/31] qcow2: Add subcluster support to discard_in_l2_slice(), Alberto Garcia, 2020/05/05
- [PATCH v5 08/31] qcow2: Add dummy has_subclusters() function, Alberto Garcia, 2020/05/05
- [PATCH v5 01/31] qcow2: Make Qcow2AioTask store the full host offset, Alberto Garcia, 2020/05/05
- [PATCH v5 03/31] qcow2: Add calculate_l2_meta(), Alberto Garcia, 2020/05/05
- [PATCH v5 11/31] qcow2: Add offset_into_subcluster() and size_to_subclusters(), Alberto Garcia, 2020/05/05
- [PATCH v5 02/31] qcow2: Convert qcow2_get_cluster_offset() into qcow2_get_host_offset(), Alberto Garcia, 2020/05/05
- [PATCH v5 18/31] qcow2: Handle QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC, Alberto Garcia, 2020/05/05
- [PATCH v5 24/31] qcow2: Update L2 bitmap in qcow2_alloc_cluster_link_l2(), Alberto Garcia, 2020/05/05
- [PATCH v5 06/31] qcow2: Add get_l2_entry() and set_l2_entry(), Alberto Garcia, 2020/05/05
- [PATCH v5 21/31] qcow2: Add subcluster support to zero_in_l2_slice(), Alberto Garcia, 2020/05/05
- [PATCH v5 15/31] qcow2: Add qcow2_cluster_is_allocated(), Alberto Garcia, 2020/05/05
- [PATCH v5 17/31] qcow2: Replace QCOW2_CLUSTER_* with QCOW2_SUBCLUSTER_*, Alberto Garcia, 2020/05/05
- [PATCH v5 30/31] qcow2: Add subcluster support to qcow2_measure(), Alberto Garcia, 2020/05/05