qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 18/18] qom: Drop @errp parameter of object_property_del()


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 18/18] qom: Drop @errp parameter of object_property_del()
Date: Tue, 5 May 2020 18:00:58 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 5/5/20 5:29 PM, Markus Armbruster wrote:
Same story as for object_property_add(): the only way
object_property_del() can fail is when the property with this name
does not exist.  Since our property names are all hardcoded, failure
is a programming error, and the appropriate way to handle it is
passing &error_abort.  Most callers do that, the commit before
previous fixed one that didn't (and got the error handling wrong), and
the two remaining exceptions ignore errors.

Drop the @errp parameter.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
---
  include/qom/object.h       | 2 +-
  hw/core/qdev.c             | 2 +-
  hw/i386/pc_sysfw.c         | 2 +-
  hw/ppc/spapr_drc.c         | 4 ++--
  qom/object.c               | 7 +------
  qom/object_interfaces.c    | 3 +--
  tests/check-qom-proplist.c | 2 +-
  7 files changed, 8 insertions(+), 14 deletions(-)

Nice :)

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]