Re: [PATCH v5 00/18] nvme: refactoring and cleanups

[Philippe Mathieu-Daudé]

On 5/5/20 7:48 AM, Klaus Jensen wrote:
> From: Klaus Jensen <address@hidden>
>
> Changes since v5
> ~~~~~~~~~~~~~~~~
> No functional changes, just updated Reviewed-by tags. Also, I screwed up
> the CC list when sending v4.
>
> Philippe and Keith, please add a Reviewed-by to
>
>    * "nvme: factor out pmr setup" and
>    * "do cmb/pmr init as part of pci init"
>
> since the first one was added and the second one was changed in v4 when
> rebasing on Kevins block-next tree which had the PMR work that was not
> in master at the time.
>
> With those in place, it should be ready for Kevin to merge.
>
> Klaus Jensen (18):
>    nvme: fix pci doorbell size calculation
>    nvme: rename trace events to pci_nvme
>    nvme: remove superfluous breaks
>    nvme: move device parameters to separate struct
>    nvme: use constants in identify
>    nvme: refactor nvme_addr_read
>    nvme: add max_ioqpairs device parameter
>    nvme: remove redundant cmbloc/cmbsz members
>    nvme: factor out property/constraint checks
>    nvme: factor out device state setup
>    nvme: factor out block backend setup
>    nvme: add namespace helpers
>    nvme: factor out namespace setup
>    nvme: factor out pci setup
>    nvme: factor out cmb setup
>    nvme: factor out pmr setup
>    nvme: do cmb/pmr init as part of pci init
>    nvme: factor out controller identify setup

Thinking loudly, it would be easier to differentiate emulated device vs 
block driver using 's,^nvme,hw/nvme,' in patches (and series) title. 
Kevin, if you are motivated...

>   hw/block/nvme.c       | 543 ++++++++++++++++++++++++------------------
>   hw/block/nvme.h       |  31 ++-
>   hw/block/trace-events | 180 +++++++-------
>   include/block/nvme.h  |   8 +
>   4 files changed, 429 insertions(+), 333 deletions(-)