[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 02/18] exec: Fix cpu_watchpoint_address_matches address length
From: |
Richard Henderson |
Subject: |
[PATCH v4 02/18] exec: Fix cpu_watchpoint_address_matches address length |
Date: |
Thu, 30 Apr 2020 09:27:57 -0700 |
The only caller of cpu_watchpoint_address_matches passes
TARGET_PAGE_SIZE, so the bug is not currently visible.
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
exec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/exec.c b/exec.c
index 2874bb5088..5162f0d12f 100644
--- a/exec.c
+++ b/exec.c
@@ -1127,7 +1127,7 @@ int cpu_watchpoint_address_matches(CPUState *cpu, vaddr
addr, vaddr len)
int ret = 0;
QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) {
- if (watchpoint_address_matches(wp, addr, TARGET_PAGE_SIZE)) {
+ if (watchpoint_address_matches(wp, addr, len)) {
ret |= wp->flags;
}
}
--
2.20.1
- [PATCH v4 00/18] target/arm: sve load/store improvements, Richard Henderson, 2020/04/30
- [PATCH v4 02/18] exec: Fix cpu_watchpoint_address_matches address length,
Richard Henderson <=
- [PATCH v4 01/18] exec: Add block comments for watchpoint routines, Richard Henderson, 2020/04/30
- [PATCH v4 03/18] accel/tcg: Add block comment for probe_access, Richard Henderson, 2020/04/30
- [PATCH v4 04/18] accel/tcg: Add probe_access_flags, Richard Henderson, 2020/04/30
- [PATCH v4 06/18] target/arm: Use cpu_*_data_ra for sve_ldst_tlb_fn, Richard Henderson, 2020/04/30
- [PATCH v4 05/18] accel/tcg: Add endian-specific cpu_{ld, st}* operations, Richard Henderson, 2020/04/30
- [PATCH v4 08/18] target/arm: Add sve infrastructure for page lookup, Richard Henderson, 2020/04/30
- [PATCH v4 07/18] target/arm: Drop manual handling of set/clear_helper_retaddr, Richard Henderson, 2020/04/30
- [PATCH v4 09/18] target/arm: Adjust interface of sve_ld1_host_fn, Richard Henderson, 2020/04/30
- [PATCH v4 10/18] target/arm: Use SVEContLdSt in sve_ld1_r, Richard Henderson, 2020/04/30
- [PATCH v4 11/18] target/arm: Handle watchpoints in sve_ld1_r, Richard Henderson, 2020/04/30