[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/6] iotests: vmdk: Enable zeroed_grained=on by default
From: |
Kevin Wolf |
Subject: |
Re: [PATCH 6/6] iotests: vmdk: Enable zeroed_grained=on by default |
Date: |
Thu, 30 Apr 2020 16:42:29 +0200 |
Am 30.04.2020 um 16:22 hat Eric Blake geschrieben:
> On 4/30/20 8:30 AM, Kevin Wolf wrote:
> > In order to avoid bitrot in the zero cluster code in VMDK, enable
> > zero_grained=on by default for the tests.
>
> Here, you spell it zero_grained=on,
Thanks for spotting this, the typo is in the commit message.
> >
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> > tests/qemu-iotests/059 | 6 +++---
> > tests/qemu-iotests/check | 3 +++
> > 2 files changed, 6 insertions(+), 3 deletions(-)
>
> So you're changing the default for better coverage and speed, but ensuring
> that 59 still covers the (slower) zero_grained=off. Seems reasonable.
The real reason why I'm changing 059 is that zeroed_grain=on works only
with some subformats and the test case tests many different subformats,
including those for which it doesn't work.
Kevin
- [PATCH 1/6] vmdk: Rename VmdkMetaData.valid to new_allocation, (continued)
- [PATCH 1/6] vmdk: Rename VmdkMetaData.valid to new_allocation, Kevin Wolf, 2020/04/30
- [PATCH 3/6] vmdk: Fix partial overwrite of zero cluster, Kevin Wolf, 2020/04/30
- [PATCH 4/6] vmdk: Don't update L2 table for zero write on zero cluster, Kevin Wolf, 2020/04/30
- [PATCH 5/6] vmdk: Flush only once in vmdk_L2update(), Kevin Wolf, 2020/04/30
- [PATCH 6/6] iotests: vmdk: Enable zeroed_grained=on by default, Kevin Wolf, 2020/04/30