Re: [PATCH 02/12] stubs: add pci_create_simple

[Philippe Mathieu-Daudé]

On 4/29/20 1:02 PM, Gerd Hoffmann wrote:
> Needed for -soundhw cleanup.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>   stubs/pci-bus.c     | 7 +++++++
>   stubs/Makefile.objs | 1 +
>   2 files changed, 8 insertions(+)
>   create mode 100644 stubs/pci-bus.c
>
> diff --git a/stubs/pci-bus.c b/stubs/pci-bus.c
> new file mode 100644
> index 000000000000..e833947f1f41
> --- /dev/null
> +++ b/stubs/pci-bus.c
> @@ -0,0 +1,7 @@
> +#include "qemu/osdep.h"
> +#include "hw/pci/pci.h"
> +
> +PCIDevice *pci_create_simple(PCIBus *bus, int devfn, const char *name)
> +{
> +    return NULL;

We want:

       g_assert_not_reached();

Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>

> +}
> diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
> index c61ff38cc801..5e7f2b3f061e 100644
> --- a/stubs/Makefile.objs
> +++ b/stubs/Makefile.objs
> @@ -40,6 +40,7 @@ stub-obj-y += target-get-monitor-def.o
>   stub-obj-y += vmgenid.o
>   stub-obj-y += xen-common.o
>   stub-obj-y += xen-hvm.o
> +stub-obj-y += pci-bus.o
>   stub-obj-y += pci-host-piix.o
>   stub-obj-y += ram-block.o
>   stub-obj-y += ramfb.o