[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/6] ramfb: a bunch of reverts and fixes
From: |
no-reply |
Subject: |
Re: [PATCH v2 0/6] ramfb: a bunch of reverts and fixes |
Date: |
Wed, 29 Apr 2020 09:37:05 -0700 (PDT) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Subject: [PATCH v2 0/6] ramfb: a bunch of reverts and fixes
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
606207c ramfb: fix size calculation
3503c7b ramfb: add sanity checks to ramfb_create_display_surface
78b6e20 ramfb: don't update RAMFBState on errors
96648223 ramfb: drop leftover debug message
329fe4e Revert "hw/display/ramfb: lock guest resolution after it's set"
9fed95d Revert "hw/display/ramfb: initialize fw-config space with xres/ yres"
=== OUTPUT BEGIN ===
1/6 Checking commit 9fed95ded1c1 (Revert "hw/display/ramfb: initialize
fw-config space with xres/ yres")
2/6 Checking commit 329fe4e6f68d (Revert "hw/display/ramfb: lock guest
resolution after it's set")
3/6 Checking commit 96648223c33a (ramfb: drop leftover debug message)
4/6 Checking commit 78b6e20dc09f (ramfb: don't update RAMFBState on errors)
ERROR: braces {} are necessary for all arms of this statement
#46: FILE: hw/display/ramfb.c:87:
+ if (!surface)
[...]
total: 1 errors, 0 warnings, 34 lines checked
Patch 4/6 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/6 Checking commit 3503c7b9d778 (ramfb: add sanity checks to
ramfb_create_display_surface)
6/6 Checking commit 606207c60d25 (ramfb: fix size calculation)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
- [PATCH v2 0/6] ramfb: a bunch of reverts and fixes, Gerd Hoffmann, 2020/04/29
- [PATCH v2 3/6] ramfb: drop leftover debug message, Gerd Hoffmann, 2020/04/29
- [PATCH v2 1/6] Revert "hw/display/ramfb: initialize fw-config space with xres/ yres", Gerd Hoffmann, 2020/04/29
- [PATCH v2 4/6] ramfb: don't update RAMFBState on errors, Gerd Hoffmann, 2020/04/29
- [PATCH v2 2/6] Revert "hw/display/ramfb: lock guest resolution after it's set", Gerd Hoffmann, 2020/04/29
- [PATCH v2 5/6] ramfb: add sanity checks to ramfb_create_display_surface, Gerd Hoffmann, 2020/04/29
- [PATCH v2 6/6] ramfb: fix size calculation, Gerd Hoffmann, 2020/04/29
- Re: [PATCH v2 0/6] ramfb: a bunch of reverts and fixes,
no-reply <=