|
From: | Eric Blake |
Subject: | Re: [PATCH v2 4/4] block: Use blk_make_empty() after commits |
Date: | Wed, 29 Apr 2020 09:55:24 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 4/29/20 9:11 AM, Max Reitz wrote:
bdrv_commit() already has a BlockBackend pointing to the BDS that we want to empty, it just has the wrong permissions. qemu-img commit has no BlockBackend pointing to the old backing file yet, but introducing one is simple. After this commit, bdrv_make_empty() is the only remaining caller of BlockDriver.bdrv_make_empty(). Signed-off-by: Max Reitz <address@hidden> --- block/commit.c | 16 +++++++++------- qemu-img.c | 19 ++++++++++++++----- 2 files changed, 23 insertions(+), 12 deletions(-)
Reviewed-by: Eric Blake <address@hidden> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |