[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 15/15] acpi: simplify build_isa_devices_aml()
From: |
Gerd Hoffmann |
Subject: |
[PATCH v3 15/15] acpi: simplify build_isa_devices_aml() |
Date: |
Wed, 29 Apr 2020 16:00:03 +0200 |
x86 machines can have a single ISA bus only.
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/i386/acpi-build.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index a8b790021974..98b3fd1cdb14 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1055,19 +1055,14 @@ static void build_hpet_aml(Aml *table)
static void build_isa_devices_aml(Aml *table)
{
bool ambiguous;
-
- Aml *scope = aml_scope("_SB.PCI0.ISA");
Object *obj = object_resolve_path_type("", TYPE_ISA_BUS, &ambiguous);
+ Aml *scope;
- if (ambiguous) {
- error_report("Multiple ISA busses, unable to define IPMI ACPI data");
- } else if (!obj) {
- error_report("No ISA bus, unable to define IPMI ACPI data");
- } else {
- build_acpi_ipmi_devices(scope, BUS(obj), "\\_SB.PCI0.ISA");
- isa_build_aml(ISA_BUS(obj), scope);
- }
+ assert(obj && !ambiguous);
+ scope = aml_scope("_SB.PCI0.ISA");
+ build_acpi_ipmi_devices(scope, BUS(obj), "\\_SB.PCI0.ISA");
+ isa_build_aml(ISA_BUS(obj), scope);
aml_append(table, scope);
}
--
2.18.2
- [PATCH v3 12/15] acpi: move aml builder code for floppy device, (continued)
- [PATCH v3 12/15] acpi: move aml builder code for floppy device, Gerd Hoffmann, 2020/04/29
- [PATCH v3 05/15] acpi: add ISADeviceClass->build_aml(), Gerd Hoffmann, 2020/04/29
- [PATCH v3 09/15] acpi: move aml builder code for serial device, Gerd Hoffmann, 2020/04/29
- [PATCH v3 14/15] acpi: factor out fw_cfg_add_acpi_dsdt(), Gerd Hoffmann, 2020/04/29
- [PATCH v3 11/15] acpi: move aml builder code for parallel device, Gerd Hoffmann, 2020/04/29
- [PATCH v3 07/15] acpi: move aml builder code for rtc device, Gerd Hoffmann, 2020/04/29
- [PATCH v3 15/15] acpi: simplify build_isa_devices_aml(),
Gerd Hoffmann <=
- [PATCH v3 13/15] acpi: move aml builder code for i8042 (kbd+mouse) device, Gerd Hoffmann, 2020/04/29
- [PATCH v3 06/15] rtc: add RTC_ISA_BASE, Gerd Hoffmann, 2020/04/29
- [PATCH v3 08/15] acpi: serial: don't use _STA method, Gerd Hoffmann, 2020/04/29
- [PATCH v3 02/15] acpi: add aml builder stubs, Gerd Hoffmann, 2020/04/29