Re: [PULL 00/32] Miscellaneous patches for 2020-04-29

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [PULL 00/32] Miscellaneous patches for 2020-04-29
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
bbf2736 qemu-option: pass NULL rather than 0 to the id of qemu_opts_set()
3736e38 libqos: Give get_machine_allocator() internal linkage
40a5fe7 fuzz: Simplify how we compute available machines and types
08bd8b8 Makefile: Drop unused, broken target recurse-fuzz
96b5543 smbus: Fix spd_data_generate() for number of banks > 2
a2b3bfe bamboo, sam460ex: Tidy up error message for unsupported RAM size
8cc9661 smbus: Fix spd_data_generate() error API violation
c6b2e22 sam460ex: Suppress useless warning on -m 32 and -m 64
8676301 qga: Fix qmp_guest_suspend_{disk, ram}() error handling
f2ba556 qga: Fix qmp_guest_get_memory_blocks() error handling
1e52928 tests/test-logging: Fix test for -dfilter 0..0xffffffffffffffff
42be747 migration/colo: Fix qmp_xen_colo_do_checkpoint() error handling
69a4ebd io: Fix qio_channel_socket_close() error handling
21ca33c xen/pt: Fix flawed conversion to realize()
0397c8f virtio-net: Fix duplex=... and speed=... error handling
c849702 bochs-display: Fix vgamem=SIZE error handling
4734313 fdc: Fix fallback=auto error handling
d40f549 arm/virt: Fix virt_machine_device_plug_cb() error API violation
669233d cpus: Proper range-checking for -icount shift=N
33e02df cpus: Fix configure_icount() error API violation
5e67774 block/file-posix: Fix check_cache_dropped() error handling
670e190 cryptodev: Fix cryptodev_builtin_cleanup() error API violation
3e5b9b0 qemu-img: Reject broken -o ""
f08bae7 qemu-img: Move is_valid_option_list() to qemu-img.c and rewrite
536796f qemu-img: Factor out accumulate_options() helper
eb08b54 qemu-option: Avoid has_help_option() in qemu_opts_parse_noisily()
f866f2c test-qemu-opts: Simplify test_has_help_option() after bug fix
42681dc qemu-option: Fix has_help_option()'s sloppy parsing
4cf9436 qemu-option: Fix sloppy recognition of "id=..." after ", , "
9b629d5 qemu-options: Factor out get_opt_name_value() helper
a85727e tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt()
fc0770d various: Remove suspicious '\' character outside of #define in C code

=== OUTPUT BEGIN ===
1/32 Checking commit fc0770db08c1 (various: Remove suspicious '\' character 
outside of #define in C code)
2/32 Checking commit a85727e34525 (tests-qemu-opts: Cover has_help_option(), 
qemu_opt_has_help_opt())
WARNING: Block comments use a leading /* on a separate line
#44: FILE: tests/test-qemu-opts.c:752:
+        { "a,b,,help", false /* BUG */, true, true },

WARNING: Block comments use a leading /* on a separate line
#45: FILE: tests/test-qemu-opts.c:753:
+        { "a,b,,?", false /* BUG */, true, true },

total: 0 errors, 2 warnings, 56 lines checked

Patch 2/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/32 Checking commit 9b629d54ce8a (qemu-options: Factor out 
get_opt_name_value() helper)
4/32 Checking commit 4cf9436358f5 (qemu-option: Fix sloppy recognition of 
"id=..." after ", , ")
5/32 Checking commit 42681dc0fb50 (qemu-option: Fix has_help_option()'s sloppy 
parsing)
6/32 Checking commit f866f2c224ff (test-qemu-opts: Simplify 
test_has_help_option() after bug fix)
7/32 Checking commit eb08b546645f (qemu-option: Avoid has_help_option() in 
qemu_opts_parse_noisily())
8/32 Checking commit 536796f458ef (qemu-img: Factor out accumulate_options() 
helper)
9/32 Checking commit f08bae71a126 (qemu-img: Move is_valid_option_list() to 
qemu-img.c and rewrite)
ERROR: suspect code indent for conditional statements (4, 4)
#63: FILE: qemu-img.c:243:
+    for (i = len; i > 0 && optarg[i - 1] == ','; i--) {
+    }

total: 1 errors, 0 warnings, 67 lines checked

Patch 9/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/32 Checking commit 3e5b9b0b2c62 (qemu-img: Reject broken -o "")
ERROR: trailing whitespace
#51: FILE: qemu-img.c:234:
+ * $

total: 1 errors, 0 warnings, 18 lines checked

Patch 10/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/32 Checking commit 670e190178ba (cryptodev: Fix cryptodev_builtin_cleanup() 
error API violation)
12/32 Checking commit 5e677748f96e (block/file-posix: Fix check_cache_dropped() 
error handling)
13/32 Checking commit 33e02df34d16 (cpus: Fix configure_icount() error API 
violation)
ERROR: consider using qemu_strtol in preference to strtol
#59: FILE: cpus.c:818:
+        time_shift = strtol(option, &rem_str, 0);

total: 1 errors, 0 warnings, 70 lines checked

Patch 13/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

14/32 Checking commit 669233d94449 (cpus: Proper range-checking for -icount 
shift=N)
15/32 Checking commit d40f549786cd (arm/virt: Fix virt_machine_device_plug_cb() 
error API violation)
16/32 Checking commit 473431395c4a (fdc: Fix fallback=auto error handling)
17/32 Checking commit c849702a667f (bochs-display: Fix vgamem=SIZE error 
handling)
18/32 Checking commit 0397c8fa48c7 (virtio-net: Fix duplex=... and speed=... 
error handling)
19/32 Checking commit 21ca33c29fec (xen/pt: Fix flawed conversion to realize())
20/32 Checking commit 69a4ebdcc79c (io: Fix qio_channel_socket_close() error 
handling)
21/32 Checking commit 42be7477a307 (migration/colo: Fix 
qmp_xen_colo_do_checkpoint() error handling)
22/32 Checking commit 1e5292888756 (tests/test-logging: Fix test for -dfilter 
0..0xffffffffffffffff)
23/32 Checking commit f2ba556c242f (qga: Fix qmp_guest_get_memory_blocks() 
error handling)
24/32 Checking commit 867630155baf (qga: Fix qmp_guest_suspend_{disk, ram}() 
error handling)
25/32 Checking commit c6b2e225677b (sam460ex: Suppress useless warning on -m 32 
and -m 64)
26/32 Checking commit 8cc9661b4025 (smbus: Fix spd_data_generate() error API 
violation)
27/32 Checking commit a2b3bfe4b4cf (bamboo, sam460ex: Tidy up error message for 
unsupported RAM size)
ERROR: unnecessary whitespace before a quoted newline
#40: FILE: hw/ppc/ppc4xx_devs.c:723:
+        error_printf("Possible valid RAM size: %" PRIi64 " MiB \n",

total: 1 errors, 0 warnings, 15 lines checked

Patch 27/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

28/32 Checking commit 96b55431cda5 (smbus: Fix spd_data_generate() for number 
of banks > 2)
29/32 Checking commit 08bd8b81657a (Makefile: Drop unused, broken target 
recurse-fuzz)
30/32 Checking commit 40a5fe78ba42 (fuzz: Simplify how we compute available 
machines and types)
31/32 Checking commit 3736e38b637e (libqos: Give get_machine_allocator() 
internal linkage)
32/32 Checking commit bbf27368e6dd (qemu-option: pass NULL rather than 0 to the 
id of qemu_opts_set())
WARNING: line over 80 characters
#48: FILE: softmmu/vl.c:3185:
+                qemu_opts_set(qemu_find_opts("machine"), NULL, "firmware", 
optarg,

total: 0 errors, 1 warnings, 31 lines checked

Patch 32/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden