Re: [PATCH v21 0/4] implement zstd cluster compression method

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v21 0/4] implement zstd cluster compression method
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
146ff2a iotests: 287: add qcow2 compression type test
694bbc7 qcow2: add zstd cluster compression
954ac0d qcow2: rework the cluster compression routine
3294c21 qcow2: introduce compression type feature

=== OUTPUT BEGIN ===
1/4 Checking commit 3294c21f8a66 (qcow2: introduce compression type feature)
2/4 Checking commit 954ac0d0a541 (qcow2: rework the cluster compression routine)
3/4 Checking commit 694bbc7bf00f (qcow2: add zstd cluster compression)
ERROR: do not use assignment in if condition
#115: FILE: block/qcow2-threads.c:225:
+    if ((zstd_ret = ZSTD_compressStream2(cctx, &output, &input, ZSTD_e_end))) {

total: 1 errors, 0 warnings, 238 lines checked

Patch 3/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/4 Checking commit 146ff2a078a9 (iotests: 287: add qcow2 compression type test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100755

total: 0 errors, 1 warnings, 228 lines checked

Patch 4/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden