[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/6] block/block-copy: move block_copy_task_create down
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [PATCH v2 5/6] block/block-copy: move block_copy_task_create down |
Date: |
Tue, 28 Apr 2020 12:17:09 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
28.04.2020 12:06, Max Reitz wrote:
On 25.03.20 14:46, Vladimir Sementsov-Ogievskiy wrote:
Simple movement without any change. It's needed for the following
patch, as this function will need to use some staff which is currently
*stuff
below it.
Wouldn’t it be simpler to just declare block_copy_task_entry()?
I just think, that it's good to keep native order of functions and avoid extra
declarations. Still, may be I care too much. No actual difference, if you
prefer declaration, I can drop this patch.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
block/block-copy.c | 66 +++++++++++++++++++++++-----------------------
1 file changed, 33 insertions(+), 33 deletions(-)
--
Best regards,
Vladimir