[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: qdev unrealize error handling WTF?!?
|
From: |
Paolo Bonzini |
|
Subject: |
Re: qdev unrealize error handling WTF?!? |
|
Date: |
Mon, 27 Apr 2020 15:44:29 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 27/04/20 14:33, Markus Armbruster wrote:
> [1] a device on dev->child_bus fails to
> unrealize, or [3] @dev itself fails to unrealize. We hold on to the
> first failure, and continue to unrealize. device_set_realized() fails
> when any of these fail.
>
> Issue #1: What if some, but not all fail? How can this possibly work?
>
> Issue #2: Even if all fail, and therefore both the device and the ones
> on ->child_bus all remain realized, there are side effects at [2] and
> [4].
>
> Any better ideas than &error_abort?
I don't think we have unrealizes that fail, so removing the argument and
&error_abort is the best idea.
Paolo